Windows users: use pip and compile it #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This unblocks us on releases, at least for OSX and Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not happy about this, but right now tensorflow doesn't have windows builds on conda-forge:
https://anaconda.org/conda-forge/tensorflow/files
and we can no longer use the defaults channel for caiman. This means binary conda packages of caiman are not going to happen on Windows until some things change, most likely a pair of things:
A) The upcoming switchover of our code from tensorflow to pytorch (but pytorch also lacks packaging on conda-forge on Windows!)
B) The upstream efforts to get pytorch's packaging issues on conda-forge on Windows fixed: conda-forge/pytorch-cpu-feedstock#231
At that point we can revert these changes and resume packaging conda packages of caiman on Windows, but for now we'll instruct them to install a compiler and use pip. (a recent pyproject diff here at least makes this temporary measure slightly more robust probably).
(we are considering adding pip support as a long-term supported install route but haven't decided on it yet)