Code

WIP: CNMFParams overhaul#1239

Code

Merged

pgunn merged 15 commits intodevflatironinstitute/CaImAn:devfrom dev-cnmfparams_jsonflatironinstitute/CaImAn:dev-cnmfparams_jsonCopy head branch name to clipboardFeb 27, 2024

+445-290

Commits

Commits on Nov 21, 2023

• cnmf/params.py: Toards json serialisation

  pgunn

  committed
  84d96a3

Commits on Nov 27, 2023

• CNMFParams:to_dict() - key names should match attributes so saves/loads are symmetric

  pgunn

  committed
  8ce73e1

• CNMFParams.change_params() - dict follows struct of object, avoids resetting unintended fields. No longer returns another reference to CNMFParams

  pgunn

  committed
  855b45a

• CNMFParams: Properly scope dict load/save functions, add json functions, adjust tests

  pgunn

  committed
  516b8d8

Commits on Nov 29, 2023

• CNMFParams.change_params() - Add allow_legacy and warn_unused flags, internally implement set()

  pgunn

  committed
  be0cd87

Commits on Dec 1, 2023

• Fix documentation on CNMFParams, document some formerly-undocumented parameters

  pgunn

  committed
  124487f

Commits on Dec 2, 2023

• params.py: import optional

  pgunn

  authored
  e3018c9

Commits on Dec 4, 2023

• CNMFParams.change_params() - Don't use set(), and track unused params everywhere

  pgunn

  committed
  92505b1

• Fix a goof in the warning infrastructure

  pgunn

  committed
  9258508

Commits on Dec 5, 2023

• CNMFParams: more typing, some docs/message tweaks, mark set_if_not_exists in set method as deprecated

  pgunn

  committed
  6e92120

Commits on Jan 31, 2024

• num_splits_to_process_els: note that it does nothing, remove some plumbing around it

  pgunn

  committed
  6894829

• Fix typo

  pgunn

  committed
  0d0ed6c

• cnmf/params.py: Improve zero check for decay time

  pgunn

  committed
  cb0f53f

Commits on Feb 27, 2024

• CNMFParams: nb parameter isn't actually used outside of the version in init

  pgunn

  committed
  d618202

• CNMFParams: Update docs to note nb removed from temporal/spatial

  pgunn

  committed
  bfc69dc