-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shared-modules for SDL2 and libdecor, permissions update #30
base: master
Are you sure you want to change the base?
Conversation
Started test build 12577 |
Forgot to @AsciiWolf |
Build 12577 successful
|
Started test build 12584 |
Build 12584 successful
|
Thanks for the PR! To be honest, I was not aware of libdecor. What advantages does it provide for common end-users? |
I've already stated them in the main issue comment: Currently, SuperTuxCart uses the runtime-provided SDL2 which doesn't provide libdecor. Therefore, it doesn't draw its own window decorations on Wayland compositors that don't implement the xdg-decoration protocol. Without window decorations, you can't drag the window around (without keybinds), minimize it, or maximize it without relying on your window manager or DE. |
Started test build 12629 |
Build 12629 successful
|
Currently, SuperTuxCart uses the runtime-provided SDL2 which doesn't provide libdecor. Therefore, it doesn't draw its own window decorations on Wayland compositors that don't implement the xdg-decoration protocol. This fixes that issue. I also reordered the permissions a bit to be a bit cleaner.
Closes #23