Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared-modules for SDL2 and libdecor, permissions update #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

orowith2os
Copy link

@orowith2os orowith2os commented Dec 19, 2022

Currently, SuperTuxCart uses the runtime-provided SDL2 which doesn't provide libdecor. Therefore, it doesn't draw its own window decorations on Wayland compositors that don't implement the xdg-decoration protocol. This fixes that issue. I also reordered the permissions a bit to be a bit cleaner.

Closes #23

@flathubbot
Copy link

Started test build 12577

@orowith2os
Copy link
Author

Forgot to @AsciiWolf

@flathubbot
Copy link

Build 12577 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/125009/net.supertuxkart.SuperTuxKart.flatpakref

@orowith2os orowith2os changed the title Use shared-modules for SDL2 and libdecor Use shared-modules for SDL2 and libdecor, permissions update Dec 19, 2022
@flathubbot
Copy link

Started test build 12584

@flathubbot
Copy link

Build 12584 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/125016/net.supertuxkart.SuperTuxKart.flatpakref

@AsciiWolf
Copy link
Collaborator

Thanks for the PR! To be honest, I was not aware of libdecor. What advantages does it provide for common end-users?

@orowith2os
Copy link
Author

Thanks for the PR! To be honest, I was not aware of libdecor. What advantages does it provide for common end-users?

I've already stated them in the main issue comment:

Currently, SuperTuxCart uses the runtime-provided SDL2 which doesn't provide libdecor. Therefore, it doesn't draw its own window decorations on Wayland compositors that don't implement the xdg-decoration protocol.

Without window decorations, you can't drag the window around (without keybinds), minimize it, or maximize it without relying on your window manager or DE.

@flathubbot
Copy link

Started test build 12629

@flathubbot
Copy link

Build 12629 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/125060/net.supertuxkart.SuperTuxKart.flatpakref

@orowith2os
Copy link
Author

Seems to be working fine over here

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord rich presence support
3 participants