-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [RFC]: Bring Flask-GoogleMaps up to date with latest dependencies #159
Draft
argysamo
wants to merge
13
commits into
flask-extensions:master
Choose a base branch
from
argysamo:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on May 6, 2024
-
WIP: Update dependencies and functionality
- Update dependencies (Flask, mypy, python >3.8) - Load javascript in an async manner - Replace obsolete `Marker` with `AdvancedMarkerElement`
Configuration menu - View commit details
-
Copy full SHA for 6fcdf85 - Browse repository at this point
Copy the full SHA 6fcdf85View commit details -
- Introduce PinElement - Minor javascript refactoring - Remove icon functionality
Configuration menu - View commit details
-
Copy full SHA for 092c5c1 - Browse repository at this point
Copy the full SHA 092c5c1View commit details -
- Replace javascript for loops with jinja. I did this in order to create "dynamic" js variables to have an "img" icon. - This is not clever though. I will revert the js loop and then use jinja2 to create the img element when needed
Configuration menu - View commit details
-
Copy full SHA for dbbda49 - Browse repository at this point
Copy the full SHA dbbda49View commit details -
WIP: Introduce Marker and MarkerContent
- MarkerContent is an abstract method. It can be either a Pin or Image - Marker object comprises of MarkerContent - Add unit tests - I am bothered by the use of `eval` method for the content
Configuration menu - View commit details
-
Copy full SHA for fe89c79 - Browse repository at this point
Copy the full SHA fe89c79View commit details -
WIP: Introduce marker_content_factory.py
- MarkerContentFactory returns the appropriate MarkerContent implementation (i.e. either Pin or Image) - Add unit tests
Configuration menu - View commit details
-
Copy full SHA for 8d91cf2 - Browse repository at this point
Copy the full SHA 8d91cf2View commit details -
- Reformat files with `black` - Update dependencies. E.g. jsmin -> 3.0.1 as this version removes the use_2to3, which creates issues with latest setuptools
Configuration menu - View commit details
-
Copy full SHA for 2fe7a6f - Browse repository at this point
Copy the full SHA 2fe7a6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c57a58 - Browse repository at this point
Copy the full SHA 9c57a58View commit details -
- Move and refactor test_map.py - Bump Python dependency to 3.9 - Use latest flake8 revision
Configuration menu - View commit details
-
Copy full SHA for 339177a - Browse repository at this point
Copy the full SHA 339177aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c419a9c - Browse repository at this point
Copy the full SHA c419a9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84f1bff - Browse repository at this point
Copy the full SHA 84f1bffView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef407be - Browse repository at this point
Copy the full SHA ef407beView commit details
Commits on May 30, 2024
-
Documentation and other updates
- Documentation: Describe the new markers setup - Remove `label` field from marker.py - Add support for `scale` for a pin.py
Configuration menu - View commit details
-
Copy full SHA for 837264f - Browse repository at this point
Copy the full SHA 837264fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4405f08 - Browse repository at this point
Copy the full SHA 4405f08View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.