feat: Add Bundle Validate methods #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvush
approved these changes
Oct 22, 2024
proxy/types.go
Outdated
| return common.BytesToHash(hash.Sum(nil)), nil | ||
| } | ||
|
|
||
| func hashMevSendBundle(b *MevSendBundleArgs, hash hash.Hash) error { |
There was a problem hiding this comment.
Lets add depth validation here too
There was a problem hiding this comment.
Added in 0bbba62
|
In case you need tests for bundle uuid, here are some of them https://github.com/flashbots/rbuilder/blob/develop/crates/rbuilder/src/primitives/serialize.rs#L607 There are also tests for mev share bundle there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This adds
Validatemethods toEthSendBundleArgsandMevSendBundleArgswhich return the canonical hash (and UUID for the case of bundles, not sure if we need this for mev-share bundles yet) or an error if the payload fails validation. Currently the validation isn't exhaustive, I wanted to get your feedback on this overall approach before going further, and of course I'd like to add unit tests to make sure that the generated hashes match our existing codebases.⛱ Motivation and Context
When processing these args on the backend we need to have the canonical hashes and UUIDs, it seems like a good idea to generate these in one spot.
📚 References
✅ I have run these commands
make lintmake testgo mod tidy