Add Mevshare protocol #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @zeroXbrock |
zeroXbrock
reviewed
Jan 5, 2024
There was a problem hiding this comment.
this is awesome, gonna save so much hassle. Just had one unresolved TODO @ferranbt not sure if you wanna merge before that's finished
src/protocols/MevShare.sol
Outdated
| request.headers = new string[](1); | ||
| request.headers[0] = "Content-Type:application/json"; | ||
| request.body = encodeBundle(bundle); | ||
| // TODO: Add Flashbots signature |
There was a problem hiding this comment.
what's needed to add the FB signature? I think we can just add the private key as a param to this function, then it's basically copypasta from the ethers lib
test/protocols/MevShare.t.sol
Outdated
| bundle.inclusionBlock = 1; | ||
|
|
||
| bundle.bodies = new bytes[](1); | ||
| bundle.bodies[0] = abi.encode(1234); |
There was a problem hiding this comment.
just a nit but might change 1234 to 0x1234. I like to use hex values directly in cases like this where you'd want to see [where] the same number shows up in the test assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a library for the Mev-Share protocol specified here