Precompile refactor and signEthTx precompile #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarzzz
reviewed
Oct 27, 2023
| // Should be proportional to bundle gas limit | ||
| return 10000 | ||
| } | ||
| chainIdInt, err := hexutil.DecodeBig(chainId) |
There was a problem hiding this comment.
should this be fully generic or only support specific chainIDs for now? just so people dont shoot themselves in the foot since we only support eth L1 rn
Ruteri
commented
Oct 27, 2023
| @@ -316,7 +316,7 @@ func parsePositionalArguments(rawArgs json.RawMessage, types []reflect.Type) ([] | |||
| // Set any missing args to nil. | |||
| for i := len(args); i < len(types); i++ { | |||
| if types[i].Kind() != reflect.Ptr { | |||
| return nil, fmt.Errorf("missing value for required argument %d", i) | |||
| return nil, fmt.Errorf("missing value for required argument %d: %s", i, string(rawArgs)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
📚 References