Engine store api #53
Merged
Engine store api #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
commented
Sep 29, 2023
| defer log.Info("bid submitted", "bid", bid, "store", r.Store) | ||
|
|
||
| var bidsByBlockAndProtocol []types.Bid | ||
| var bidsByBlockAndProtocol []suave.BidId |
There was a problem hiding this comment.
The indexing was changed to include only the bid id and no add extra space storing the bids again.
ferranbt
commented
Sep 29, 2023
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func testBackendStore(t *testing.T, store suave.ConfidentialStoreBackend) { |
There was a problem hiding this comment.
A generic testing suite for any type of backend store.
1 task
Ruteri
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR solidifies the API of the engine store. Due to the old
mempooland thestoreusing differentBidtypes, once the APIs were merged in a single interface in #51 the result was not ideal:FetchEngineBidByIdandFetchBidByIddoing the same thing but returning different types.SubmitBidmethod that only did indexing byversionanddecryptConfiditonwere the same functionality could be merged insideInitializeBid.📚 References