Simplify dastore backend #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
commented
Sep 29, 2023
| return nil | ||
| } | ||
|
|
||
| func (r *MiniredisBackend) FetchEngineBidById(bidId suave.BidId) (suave.Bid, error) { |
There was a problem hiding this comment.
These functions were copy/paste from the Redis backend.
ferranbt
commented
Sep 29, 2023
| local *miniredis.Miniredis | ||
| } | ||
|
|
||
| func NewLocalConfidentialStore() *RedisStoreBackend { |
There was a problem hiding this comment.
We can use the miniredis version of the RedisStoreBackend that works in memory as the local store.
ferranbt
commented
Sep 29, 2023
| @@ -39,6 +45,16 @@ func NewRedisStoreBackend(redisUri string) *RedisStoreBackend { | |||
| } | |||
|
|
|||
| func (r *RedisStoreBackend) Start() error { | |||
| if r.redisUri == "" { | |||
| // create a mini-redis instance | |||
There was a problem hiding this comment.
It defaults to local miniredis if no endpoint is specified. Then, the rest of the store works for both remote/local Redis.
Ruteri
approved these changes
Sep 29, 2023
Ruteri
reviewed
Sep 29, 2023
| suave "github.com/ethereum/go-ethereum/suave/core" | ||
| ) | ||
|
|
||
| type LocalConfidentialStore struct { |
There was a problem hiding this comment.
I'd maybe leave local store in since it's easy to debug with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR simplifies the Confidential Store implementations to a single Redis implementation. The other two (removed in this PR) are versions of that Redis implementation.
📚 References