Add metrics for counter and time spent on a suave precompile #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
commented
Sep 21, 2023
| @@ -51,6 +54,16 @@ func (p *SuavePrecompiledContractWrapper) Run(input []byte) ([]byte, error) { | |||
| }, | |||
| } | |||
|
|
|||
| if metrics.EnabledExpensive { | |||
| precompileName := artifacts.ResolvePrecompileAddr(p.addr) | |||
| metrics.GetOrRegisterMeter("suave/runtime/"+precompileName, nil).Mark(1) | |||
There was a problem hiding this comment.
Feel free to propose another naming for the metric.
ferranbt
commented
Sep 21, 2023
| @@ -303,9 +303,22 @@ import ( | |||
| "github.com/ethereum/go-ethereum/common" | |||
| ) | |||
|
|
|||
| // List of suave precompile addresses | |||
| var ( {{range .Functions}}{{.Name}}Addr = common.HexToAddress("{{.Address}}") | |||
There was a problem hiding this comment.
The same thing is done in #40. Once both things are merged I will consolidate this in a single place.
metachris
reviewed
Sep 21, 2023
suave/artifacts/addresses.go
Outdated
| "submitEthBlockBidToRelay": submitEthBlockBidToRelayAddr, | ||
| } | ||
|
|
||
| func ResolvePrecompileAddr(addr common.Address) string { |
There was a problem hiding this comment.
perhaps more explicit could be PrecompileAddressToName?
Ruteri
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR enables metrics to track how many times a SUAVE precompile gets called and how much time does it take to execute it.
📚 References