Sign CCRs as EIP-712 messages #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarzzz
reviewed
May 27, 2024
core/types/confidential.go
Outdated
| @@ -17,6 +17,9 @@ type ConfidentialComputeRecord struct { | |||
| KettleAddress common.Address | |||
| ConfidentialInputsHash common.Hash | |||
|
|
|||
| // Envelope signals whether this CCR was signed using EIP-712 | |||
| Envelope bool | |||
There was a problem hiding this comment.
nit: this feels not very descriptive
There was a problem hiding this comment.
Agree, what about EIP712SigningSchema: bool?
There was a problem hiding this comment.
Since you two may not fully grasp the context, please let me know if my comments are off the mark.
This is a boolean, so I feel that using a format like IsXxx would improve readability. What do you think?
For example, how about simply using IsEIP712: bool or something similar?
There was a problem hiding this comment.
I like IsEIP712 or SignedWithEIP712
zeroXbrock
reviewed
May 28, 2024
| "ConfidentialRecord": []eip712.Type{ | ||
| {Name: "nonce", Type: "uint64"}, | ||
| {Name: "gasPrice", Type: "uint256"}, | ||
| {Name: "gas", Type: "uint64"}, |
There was a problem hiding this comment.
should this uint64 be a uint256?
* remove chainId from EIP712 msg domain * use verifyingContract in eip712 domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR introduces CCRs that are signed with EIP-712 signatures. It introduces two changes:
signer/core/eip712package with theEIP-712logic copied fromsigner/core/apitypeswhich due to some dependencies of the packagetypeswas not possible to use without a circular dependency. So, I copied to the new package only the core primitives.Envelopein theConfidentialComputeRequestobject. If the fieldEnvelopeis not set, we use theeip-2718rules to generate the signing hash. If the fieldEnvelopeis set, we generate the signing hash as anEIP-712envelope.All the tests in e2e are using by default the new EIP-712 signing scheme.
📚 References