Fixes gas estimation for ccrs #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
commented
Feb 26, 2024
ferranbt
commented
Feb 26, 2024
ferranbt
commented
Feb 26, 2024
ferranbt
commented
Feb 26, 2024
internal/ethapi/api.go
Outdated
| @@ -2017,7 +2017,7 @@ func runMEVM(ctx context.Context, b Backend, state *state.StateDB, header *types | |||
| } | |||
|
|
|||
| if result.Failed() { | |||
| return nil, nil, nil, fmt.Errorf("%w: %s", result.Err, hexutil.Encode(result.Revert())) | |||
| return nil, result, storeFinalize, nil | |||
There was a problem hiding this comment.
result.Failed() indicates an error during the execution but it should not be treated as a fatal error for the call. Functions that use runMEVM need to differentiate between fatal errors and execution errors.
ferranbt
changed the title
dmarzzz
approved these changes
Feb 26, 2024
lthibault
suggested changes
Feb 26, 2024
internal/ethapi/api.go
Outdated
| @@ -2017,7 +2017,7 @@ func runMEVM(ctx context.Context, b Backend, state *state.StateDB, header *types | |||
| } | |||
|
|
|||
| if result.Failed() { | |||
| return nil, nil, nil, fmt.Errorf("%w: %s", result.Err, hexutil.Encode(result.Revert())) | |||
| return nil, result, storeFinalize, nil | |||
| require.Equal(t, bids[0].Id, record.Id) | ||
| // fetch the records and validate that it is empty since a call should not modify the store | ||
| vals := fr.callPrecompile("fetchDataRecords", []interface{}{uint64(0), "default:v0:ethBundles"}) | ||
| require.Len(t, vals[0], 0) |
There was a problem hiding this comment.
Are we certain that vals always has a nonzero length?
There was a problem hiding this comment.
Yup, enforced in callPrecompile. callPrecompile fails if it cannot decode the output of fetchDataRecords and fetchDataRecords always returns one item, the data record.
| valRaw := doCall("confidentialRetrieve", record.Id, "a") | ||
| require.Equal(t, val, valRaw[0]) | ||
| vals = fr.callPrecompile("fetchDataRecords", []interface{}{uint64(0), "default:v0:ethBundles"}) | ||
| require.Len(t, vals[0], 0) |
There was a problem hiding this comment.
Same question about len(vals). Just want to make sure the test doesn't panic instead of failing cleanly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR fixes gas estimation for Confidential Compute requests. There were a few small issues here and there. Notes on the code as comments.
📚 References