Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate version and tag match during release #204

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Validate version and tag match during release #204

merged 1 commit into from
Feb 20, 2024

Conversation

ferranbt
Copy link
Collaborator

📝 Summary

This PR adds a validation step to check that the version that suave-geth returns matches the one from the tag.

📚 References

  • I have seen and agree to CONTRIBUTING.md

lthibault
lthibault approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@lthibault lthibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick awk skills, bro. 😃

@ferranbt ferranbt merged commit e84e2e4 into main Feb 20, 2024
4 checks passed
@ferranbt ferranbt deleted the ci-release-validate-tag branch February 20, 2024 21:03
@metachris
Copy link
Contributor

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lthibault lthibault lthibault approved these changes

@Ruteri Ruteri Awaiting requested review from Ruteri Ruteri is a code owner

@metachris metachris Awaiting requested review from metachris metachris is a code owner

@dmarzzz dmarzzz Awaiting requested review from dmarzzz dmarzzz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferranbt @metachris @lthibault