-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUAVE dns #196
SUAVE dns #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, could you write a unit test for the contracts_suave.go
change and then another e2e integration? (suave/e2e
).
Another question, I think the kettle should also define the port of the service. WDYT?
@ferranbt Yeah I was also wondering if the kettle should set the port as well but that wouldn't be dns anymore. And also, if we are thinking of usage patterns like: Suavex.simulateTxn("goerlisuavex", ...) we should call this endpoint aliasing rather than dns. How about we just map a nickname such as "goerli" to a full url like "http://goerli.my-rpc.com:8545" rather than mimicking dns? |
@ferranbt After giving it some thought, I believe it's a better practice for developers if we resolve an alias name directly to its full URL, port included. It simplifies things by hiding the complexities of the URL endpoint. Let me know if you think otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment to resolve but it is minor since the tests work.
📝 Summary
Introduces SuaveEthRemoteBackendEnpointV2 flag to support multi domain kettle.
suave.eth.remote-endpoint
now accepts rpc endpoint configuration formatted inchain_id=rpc_url
📚 References
Generalizing suave execution namespace for multiple chains: flashbots/suave-specs#79