Feature/max concurrent builder session #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allnil
requested review from
ferranbt,
Ruteri,
metachris and
dmarzzz
as code owners
|
I made it work but I don't know how idiomatic it is in the context of the whole repo. |
|
Thank you for your contribution! Two comments from my side. First, we are moving the backend builder implementation to an independent repository in suave-execution-geth. Could you make the PR there? Also, we are always very mindful when adding new dependencies so I would prefer not to add a new one ( |
|
@ferranbt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft adding env var configuration for SessionManager
Will play with it in this PR,
started with Viper and config init from the environment with Viper