Limit number of open sessions #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hack because we're relying on session timeout behavior. Recommend ref-counting API that releases refs when block-height changes.
lthibault
commented
Jan 18, 2024
|
Test passes locally ... re-running 🧐 |
lthibault
requested review from
ferranbt,
Ruteri,
metachris and
dmarzzz
as code owners
|
I'm noticing that failing test is potentially non-deterministic. Did I break something, or was this always flaky? Test passes on my laptop, so I am unable to easily answer this with |
|
tests passed now. sadly, geth tests are notoriously flaky. |
ferranbt
approved these changes
Jan 19, 2024
metachris
reviewed
Jan 19, 2024
|
nice code and comments. is there a good way to write a test ensuring it works as expected? |
|
Added unit tests. @metachris I think it's a good idea to hook in a envvar flag here, but I'd like to do it in a separate PR because it'll affect a different set of modules. Merging now and following up with that change. |
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Use a semaphore channel to limit the number of open sessions. This is a hack because we're relying on session timeout behavior. Recommend ref-counting API that releases refs when block-height changes in near-term future.
Resolves #153
📚 References