Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom timeout in transaction result sdk #159

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add custom timeout in transaction result sdk #159

merged 2 commits into from
Jan 16, 2024

Conversation

ferranbt
Copy link
Collaborator

📝 Summary

This PR adds a custom timeout for mined transactions in the sdk. Otherwise, the default timeout is too short for most chains.

📚 References

  • I have seen and agree to CONTRIBUTING.md

@ferranbt ferranbt mentioned this pull request Jan 11, 2024
Merged
dmarzzz
dmarzzz approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@dmarzzz dmarzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSTM

@ferranbt ferranbt merged commit 29dd186 into main Jan 16, 2024
3 checks passed
@ferranbt ferranbt deleted the sdk/add-custom-timeout branch January 16, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmarzzz dmarzzz dmarzzz approved these changes

@Ruteri Ruteri Awaiting requested review from Ruteri Ruteri is a code owner

@metachris metachris Awaiting requested review from metachris metachris is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferranbt @dmarzzz