Use a deterministic address if none is provided in --dev mode #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
In dev mode (
--dev), If no keystore is mounted in the client,gethgenerates a random address as the validator and funded account.gethdoes not provide the private key of this funded account to make transactions. Normally, this is not a problem because a user can send a non-signedeth_sendTransactionwhich uses that funded account.However, the
eth_sendTransactionmethod was disabled in #34. Thus, if a node runs in dev mode without a keystone, no transactions can be mined ever.This PR fixes that issue by generating a deterministic address with a known private key as a validator/funded account. The address picked is the one generated by the mnemonic
test test test test test test test test test test test junkwhich is the same one used by foundry for this use case.📚 References