Add goreleaser #146
Add goreleaser #146
Conversation
.github/workflows/releaser.yml
Outdated
| username: ${{ github.repository_owner }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Publich ref name |
.github/workflows/releaser.yml
Outdated
| - name: Login to GHCR | ||
| uses: docker/login-action@v2 | ||
| with: | ||
| registry: ghcr.io |
There was a problem hiding this comment.
let's use docker hub, i'll help set this up
There was a problem hiding this comment.
wdyt?
probably docker hub is more common and easier to use, as you don't need to be logged into github (it's more easily accessible)
I've created https://hub.docker.com/r/flashbots/suave-geth and added env vars to the repo settings
There was a problem hiding this comment.
Did you set DOCKERHUB_USERNAME and DOCKERHUB_TOKEN?
|
nice work! |
Makefile
Outdated
| -v `pwd`/sysroot:/sysroot \ | ||
| -w /go/src/$(PACKAGE_NAME) \ | ||
| ghcr.io/goreleaser/goreleaser-cross:v1.19.5 \ | ||
| release --clean --release-notes /build/changelog.md |
There was a problem hiding this comment.
i think it'd be better to create a draft release here, and manually edit the description and publish when ready
.github/workflows/releaser.yml
Outdated
| username: ${{ github.repository_owner }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Publich ref name |
There was a problem hiding this comment.
| - name: Publich ref name | |
| - name: Public ref name |
There was a problem hiding this comment.
Updated to Log tag name
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Publich ref name | ||
| run: echo "Build for tag ${{ github.ref_name }}" |
There was a problem hiding this comment.
does this work? in the past I've had to use this way:
https://github.com/flashbots/mev-boost/blob/develop/.github/workflows/release.yaml#L20-L26
There was a problem hiding this comment.
Yes, check this execution log https://github.com/ferranbt/suave-geth/actions/runs/7446372136/job/20256482872
📝 Summary
This PR introduces
goreleaserto build releases forlinux,darwinandwindowswithcgoenabled. It also producesdockerimages and pushes them toghcr.📚 References