Validate for duplicated names/addrs in precompile spec #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
approved these changes
Dec 19, 2023
dmarzzz
pushed a commit
that referenced
this pull request
Dec 22, 2023
dmarzzz
added a commit
that referenced
this pull request
Dec 22, 2023
* add signMessage precompile * precompile implementation * chore: remove http.port flag in dev mode (#125) * Fix console cmd for suave devnet (#122) * err on suave precompile is type ErrExecutionReverted (#129) * err on suave precompile is type ErrExecutionReverted * restrict go version to 1.21.1 * Add PeekerReverted error to Suave abi (#130) * Add PeekerReverted error to Suave abi * Commit real one * Add precompile to make remote http calls (#110) * Add precompile to make remote http calls * Fix error * Handle error and integrate other external calls * Last fixes * Fix * Show more diffs * Fix test * Validate for duplicated names/addrs in precompile spec (#132) * bid -> dataRecord (#128) * bid -> dataRecord * working renames * change FetchBid to FetchRecord * update vm contracts * update devenv mevshare script * the last references of bid * the LAST improper bid reference * Add format to Solidity --------- Co-authored-by: Ferran Borreguero <[email protected]> * Add console2 log support (#126) * Add console log support * Fix lint * [fix] fix bootnode's address (#134) * add signMessage precompile * precompile implementation * update artifacts * fix bad merge * cherrypick and update libs * regen --------- Co-authored-by: Yash Atreya <[email protected]> Co-authored-by: Ferran Borreguero <[email protected]> Co-authored-by: halo3mic <[email protected]> Co-authored-by: Ferran Borreguero <[email protected]> Co-authored-by: Anton <[email protected]> Co-authored-by: Andy Tudhope <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR validates that in the
suave_spec.ymltwo precompiles cannot have the same name or address.📚 References