POC : Request results pattern #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
reviewed
Dec 18, 2023
| type SubmissionResults struct { | ||
| StatusCode uint64 | ||
| Destination string | ||
| RoundTripTime *big.Int |
There was a problem hiding this comment.
instead of bigInt complexity, perhaps go for uint64 in millis? or alternatively record startTimeUnix and endTimeUnix 🤔
also the unit here should be self-apparent
There was a problem hiding this comment.
totally, great suggestions! just threw together something quick to illustrate
|
using #109 we could actually just automatically leak this event on precompile calls. This of course forces the dapp into it. But the info leak is really more of a concern for the kettle as you can triangulate it's location by this (maybe not a bad thing!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This is a simple PoC of a logging pattern we could use to help display more information in the block explorer to help guide users on their SUAPPs internals.
We could then alter the block explorer to something like this (don't read into the screenshot too much, I simply googled "networking UI" and photo shopped it into a screen shot of the explorer)
📚 References