Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format e2e contracts and ci check #118

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

ferranbt
Copy link
Collaborator

@ferranbt ferranbt commented Dec 5, 2023

📝 Summary

This PR formats the contracts in e2e and adds a CI check to validate them. You can format the contracts by running make fmt-contracts.

You can also use the Solidity vscode extension with this setting (vscode/settings.json) to format on save:

{
    "editor.formatOnSave": true,
    "[solidity]": {
        "editor.defaultFormatter": "JuanBlanco.solidity" 
      },
    "solidity.compileUsingRemoteVersion": "v0.8.16",
    "solidity.formatter": "forge",
    "solidity.packageDefaultDependenciesContractsDirectory": "src",
    "solidity.packageDefaultDependenciesDirectory": "lib"
}

📚 References


  • I have seen and agree to CONTRIBUTING.md

@ferranbt ferranbt merged commit 11f4230 into main Dec 7, 2023
3 checks passed
@ferranbt ferranbt deleted the feature/format-contracts branch December 7, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants