-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use pending txs to build blocks #116
Conversation
I like it, small nit but maybe fillPending is a better name? |
e4d6689
to
4d6b0a4
Compare
Sure! Just to clarify, |
the first, my thinking is roughly: btw, do you mind adding this change to the specs as well, you might need to update precompile and the suave ex namespace section. |
Made the renaming changes. Regarding the spec update, I didn't find anything mentioning the composition of |
@halo3mic can you rebase this? |
a230df4
to
339c75a
Compare
Rebased! |
📝 Summary
Motivation
Spend less Goerli ETH building Goerli blocks via Suave.
Solution
Optionally include pending transactions while building a block via
suavex_buildEthBlock
andsuavex_buildEthBlockFromBundles
.