Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pending txs to build blocks #116

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Conversation

halo3mic
Copy link
Contributor

@halo3mic halo3mic commented Dec 4, 2023

📝 Summary

Motivation

Spend less Goerli ETH building Goerli blocks via Suave.

Solution

Optionally include pending transactions while building a block via suavex_buildEthBlock and suavex_buildEthBlockFromBundles.


  • I have seen and agree to CONTRIBUTING.md

@dmarzzz
Copy link
Member

dmarzzz commented Dec 4, 2023

I like it, small nit but maybe fillPending is a better name?

@halo3mic
Copy link
Contributor Author

halo3mic commented Dec 4, 2023

I like it, small nit but maybe fillPending is a better name?

Sure! Just to clarify, usePending -> fillPending or commitPendingTxs -> fillPending?

@dmarzzz
Copy link
Member

dmarzzz commented Dec 5, 2023

Sure! Just to clarify, usePending -> fillPending or commitPendingTxs -> fillPending?

the first, my thinking is roughly: usePending only means use pending transactions when actually what this is doing is filling the rest of the block with pending transactions

btw, do you mind adding this change to the specs as well, you might need to update precompile and the suave ex namespace section.

@halo3mic
Copy link
Contributor Author

halo3mic commented Dec 5, 2023

fillPending

Sure! Just to clarify, usePending -> fillPending or commitPendingTxs -> fillPending?

the first, my thinking is roughly: usePending only means use pending transactions when actually what this is doing is filling the rest of the block with pending transactions

btw, do you mind adding this change to the [specs](https://github.com/flashbots/suave-

Made the renaming changes. Regarding the spec update, I didn't find anything mentioning the composition of BuildBlockArgs ... not really confident about where exactly to add the struct definition in precompiles and suavex call.

@dmarzzz
Copy link
Member

dmarzzz commented Dec 22, 2023

@halo3mic can you rebase this?

@halo3mic
Copy link
Contributor Author

@halo3mic can you rebase this?

Rebased!

@dmarzzz dmarzzz merged commit 95ae32e into flashbots:main Jan 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants