Skip to content

Commit

Permalink
Address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
ferranbt committed Feb 29, 2024
1 parent 4b4cf9b commit 81c87ea
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion internal/ethapi/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -2059,7 +2059,6 @@ func runMEVM(ctx context.Context, b Backend, state *state.StateDB, header *types
return nil, nil, nil, err
}

// add some magic number and the result (TODO)
computeResult = append(computeResult, magicBytes...)
computeResult = append(computeResult, logsEncoded...)
}
Expand Down
2 changes: 1 addition & 1 deletion suave/e2e/workflow_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1072,7 +1072,7 @@ func TestE2E_EmitLogs_Basic(t *testing.T) {
require.Len(t, receipt.Logs, 1)
require.Equal(t, receipt.Logs[0].Address, contractAddr)

data, err := exampleCallSourceContract.Abi.Events["LogCallback"].Inputs.Unpack(receipt.Logs[0].Data)
data, err := exampleCallSourceContract.Abi.Events["OffchainLogs"].Inputs.Unpack(receipt.Logs[0].Data)
require.NoError(t, err)

execResultBytes := data[0].([]byte)
Expand Down
4 changes: 2 additions & 2 deletions suave/sol/standard_peekers/example.sol
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ contract ExampleEthCallSource {
return abi.encodeWithSelector(this.emptyCallback.selector);
}

event LogCallback(bytes data);
event OffchainLogs(bytes data);

function emitLogCallback(uint256 num) public {
// From the msg.input, the 'confidential context' sequence
Expand All @@ -63,7 +63,7 @@ contract ExampleEthCallSource {
dataToDecode[i] = inputData[magicSequenceIndex + i];
}

emit LogCallback(dataToDecode);
emit OffchainLogs(dataToDecode);
}

// Event with no indexed parameters
Expand Down

0 comments on commit 81c87ea

Please sign in to comment.