Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment corrections #72

Merged
merged 9 commits into from
Jul 19, 2024
Merged

Comment corrections #72

merged 9 commits into from
Jul 19, 2024

Conversation

ZanCorDX
Copy link
Contributor

📝 Summary

Missing corrections I missed to add on a previous PR (#53).

@ZanCorDX ZanCorDX requested a review from dvush as a code owner July 18, 2024 20:41
Copy link

github-actions bot commented Jul 18, 2024

Benchmark results for b76f5ad

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/b76f5ad-35a5191/report/index.html

Date (UTC) 2024-07-18T22:06:49+00:00
Commit b76f5ad7a01bc414fa425fd3c075e4af493cad24
Base SHA 35a5191b76facd8c458c00b135983e2c49ccb0a8

Significant changes

Benchmark Mean Status
MEV-Boost SubmitBlock serialization/JSON encoding -7.22% Performance has improved.

Copy link
Member

@fiiiu fiiiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a bunch of NITs on punctuation, capitalization, etc..

@ZanCorDX ZanCorDX merged commit d0db85e into develop Jul 19, 2024
2 checks passed
@ZanCorDX ZanCorDX deleted the more-comments-corrections branch July 19, 2024 10:48
MoeMahhouk pushed a commit that referenced this pull request Jul 29, 2024
## 📝 Summary

Missing corrections I missed to add on a previous PR
(#53).

---------

Co-authored-by: Alejo Salles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants