New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proc macros to ignore tests if env or http not set #36

Merged

dvush merged 2 commits into develop from ferranbt/macro-ignore-tests-if-context-not-set

Jul 8, 2024

Contributor

ferranbt commented Jul 6, 2024

📝 Summary

This PR creates two new procedural macro (and crate otherwise it does not work) that:

Ignore a test if some env variable is not set.
Ignore a test if some endpoint is not available.

✅ I have completed the following steps:

Run make lint
Run make test
Added tests (if applicable)


          Add proc macros to ignore tests if env or http not set

33082f8

ferranbt requested review from dvush, ZanCorDX, metachris and jakubhruby7 as code owners

July 6, 2024 12:03

github-actions bot commented Jul 6, 2024 •

edited

Loading

Benchmark results for `d648cb6`

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/d648cb6-882ce81/report/index.html


Date (UTC)	2024-07-06T12:08:44+00:00
Commit	`d648cb60033c2f6b80782eab734573e5aa371c24`
Base SHA	`882ce817d5dc10f63d37a31c42ebe47686954252`

Significant changes

None


          Fix lint

d648cb6

ryanschneider approved these changes

View reviewed changes

Contributor

ryanschneider left a comment

Great idea, lgtm!

dvush approved these changes

View reviewed changes

dvush merged commit b2cb717 into develop

2 checks passed

dvush deleted the ferranbt/macro-ignore-tests-if-context-not-set branch

July 8, 2024 16:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dvush dvush approved these changes

ryanschneider ryanschneider approved these changes

ZanCorDX Awaiting requested review from ZanCorDX ZanCorDX is a code owner

metachris Awaiting requested review from metachris metachris is a code owner

jakubhruby7 Awaiting requested review from jakubhruby7

Labels

None yet