Add list of default relays and config to enable them #321
+187
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
requested review from
dvush,
ZanCorDX,
liamaharon and
metachris
as code owners
|
There is still something missing here because I cannot merge with the default config. |
Benchmark results for
|
| Date (UTC) | 2025-01-06T18:56:52+00:00 |
| Commit | d06617c33d6e62c40109b0b045b53131d652f132 |
| Base SHA | 06840a87a5330a776f1566f7831b406738616b96 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| cloning_3000_branch_node_size_elements | 2.35% | Performance has degraded. |
| hashing_3000_elements_with_cache | 2.77% | Performance has degraded. |
| gather_nodes_big_changes_account | 2.17% | Performance has degraded. |
| gather_nodes_storage_tries | 5.81% | Performance has degraded. |
| MEV-Boost SubmitBlock serialization/JSON encoding | -7.21% | Performance has improved. |
| gather_nodes_empty_account | 2.82% | Performance has degraded. |
ZanCorDX
reviewed
Jan 3, 2025
| @@ -169,9 +173,47 @@ impl L1Config { | |||
| } | |||
|
|
|||
| pub fn create_relays(&self) -> eyre::Result<Vec<MevBoostRelay>> { | |||
| let mut relays = DEFAULT_RELAYS.to_vec(); | |||
There was a problem hiding this comment.
Wouldn't it feel more natural/easy to use a map string->cfg instead of vector + find name?
ZanCorDX
reviewed
Jan 3, 2025
| @@ -11,7 +12,8 @@ pub type MevBoostRelayID = String; | |||
| #[serde(deny_unknown_fields)] | |||
| pub struct RelayConfig { | |||
| pub name: String, | |||
| pub url: String, | |||
| pub url: Option<String>, | |||
There was a problem hiding this comment.
A RelayConfig with no url makes no sense. Why the Option?
There was a problem hiding this comment.
The idea is to be able to update one of the default relays like:
relays = ["flashbots"]
[[relays]]
name = "flashbots"
use_gzip_for_submit = true
But this cannot be done because url is required.
ZanCorDX
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #305
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test