Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all benchmarks in make bench and CI #292

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

0xmichalis
Copy link
Contributor

@0xmichalis 0xmichalis commented Dec 18, 2024

πŸ“ Summary

Run the existing root hash benchmarks in make bench and CI, alongside all other existing benchmarks found in rbuilder (part of #30)

βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@0xmichalis 0xmichalis marked this pull request as draft December 18, 2024 11:51
@dvush
Copy link
Contributor

dvush commented Dec 18, 2024

Hi!

This repo already contains proper benchmarks for root hash in the eth-sparse-mpt directory. That includes microbenchmarks for different parts of the calculation and e2e benchmark for real block root hash (without db).

@0xmichalis
Copy link
Contributor Author

0xmichalis commented Dec 18, 2024

@dvush I see, thanks! I don't see these benchmarks run when running make bench, is that expected? I suppose they don't end up running in CI?

EDIT: Updated the make command and CI script to include these benchmarks.

@0xmichalis 0xmichalis changed the title Bench roothash Run all benchmarks in make bench and CI Dec 18, 2024
@0xmichalis 0xmichalis changed the title Run all benchmarks in make bench and CI Run all benchmarks in make bench and CI Dec 18, 2024
@0xmichalis 0xmichalis marked this pull request as ready for review December 18, 2024 14:19
Copy link

Benchmark results for 82c503f

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/82c503f-752223d/report/index.html

Date (UTC) 2024-12-18T14:21:26+00:00
Commit 82c503f7cb7b9f9d732cdfc1f818f51c8adc86d7
Base SHA 752223d32b3006dc6da77a5320858ff7622f8bae

Significant changes

Benchmark Mean Status
gather_nodes_clone 12.14% Performance has degraded.
hashing_3000_branch_node_size_elements -3.70% Performance has improved.
hashing_3000_elements -3.15% Performance has improved.
MEV-Boost SubmitBlock serialization/JSON encoding -38.31% Performance has improved.

@ferranbt ferranbt merged commit 2e4c1ab into flashbots:develop Dec 18, 2024
6 checks passed
@0xmichalis 0xmichalis deleted the bench-roothash branch December 18, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants