Add preset builders to the default config #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
requested review from
dvush,
ZanCorDX,
liamaharon and
metachris
as code owners
Benchmark results for
|
| Date (UTC) | 2024-12-17T09:11:20+00:00 |
| Commit | 45ad71e112729abc71fe0fd842f2f2f6c23fca86 |
| Base SHA | 171d8fcb2de834b6d46463979f8643756c599e86 |
Significant changes
None
ZanCorDX
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Currently, users need to manually configure block builders by writing out full builder configurations. However, there are only a limited number of meaningful builder configurations that make sense in practice and are allowed on the builder algos. Having users write custom configurations is unnecessary complexity when we can provide all the practical presets out of the box.
This PR provides all the meaningful builder configurations as ready-to-use presets. Users can simply enable the builders they need instead of dealing with detailed configuration. This PR is backwards compatible, the users can still provide their own builder configurations.
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test