Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Reth to 1.1.2 #288

Merged
merged 13 commits into from
Dec 18, 2024
Merged

Bump Reth to 1.1.2 #288

merged 13 commits into from
Dec 18, 2024

Conversation

moricho
Copy link
Contributor

@moricho moricho commented Dec 14, 2024

📝 Summary

Updated Reth to version 1.1.2. The following changes are included in this update:

  • Renamed Optimism-related types: OpHardforks, OpPayloadBuilderError, OpAddOns
  • Changed the 2nd argument of get_block_by_number from bool to BlockTransactionsKind
  • Used getter methods to access certain fields (e.g., hash, nonce) in the Transaction object
  • Renamed the miner field in Header to beneficiary
  • Updated some import paths
  • Used PrimitiveSignature instead of Signature

💡 Motivation and Context

To catch up with the newer version of Reth


✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@moricho moricho changed the title [WIP] Bump reth to 1.1.2 [WIP] Bump Reth to 1.1.2 Dec 14, 2024
@moricho moricho changed the title [WIP] Bump Reth to 1.1.2 Bump Reth to 1.1.2 Dec 14, 2024
@moricho moricho marked this pull request as ready for review December 14, 2024 07:41
Copy link

github-actions bot commented Dec 14, 2024

Benchmark results for 75810aa

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/75810aa-171d8fc/report/index.html

Date (UTC) 2024-12-14T21:47:33+00:00
Commit 75810aa43be69ad07b02c3e12270775c0199526e
Base SHA 171d8fcb2de834b6d46463979f8643756c599e86

Significant changes

None

Copy link
Contributor

@ryanschneider ryanschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well!

@ferranbt ferranbt merged commit 752223d into flashbots:develop Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants