Disable watchdog if watchdog_timeout_sec config is 0 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark results for
|
| Date (UTC) | 2024-12-03T14:50:30+00:00 |
| Commit | b2b8d3b57d404a0e5df8462be3a33d21fced0913 |
| Base SHA | af6f94ab6f97bea9ce19377c1df255d3b9b73004 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| MEV-Boost SubmitBlock serialization/JSON encoding | -4.54% | Performance has improved. |
liamaharon
approved these changes
Dec 3, 2024
ZanCorDX
requested changes
Dec 3, 2024
There was a problem hiding this comment.
I don't like hacky constants like 0. I would prefeer to make watchdog_timeout_sec Option in the cfg. The only caveat would be that it would not be fully bacwards compatible since before not having watchdog_timeout_sec would default to 3 min but we don' really use that.
|
null object pattern would be nice although for this case, it may be too much (I'll have to copy/paste your changes into multioperator for the other use of the watchdog). |
ZanCorDX
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR disables the watchdog if the value from config is zero.
✅ I have completed the following steps:
make lintmake test