add reth-rbuilder as an artifact target in CI
#262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukoneck
requested review from
dvush,
ZanCorDX,
ferranbt,
liamaharon and
metachris
as code owners
sukoneck
changed the title
reth-rbuilder as an artifact target in CI
ferranbt
reviewed
Dec 3, 2024
| target: ${{ matrix.configs.target }} | ||
|
|
||
| # https://github.com/WarpBuilds/rust-cache | ||
| - name: Run WarpBuilds/rust-cache |
There was a problem hiding this comment.
How does this change affect build times?
There was a problem hiding this comment.
good question. it's not significantly different. we're building in parallel for 5-10 minutes per binary, which is a ~1 minute longer. we can reintroduce with a bit of work if build times become an issue.
ferranbt
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
reth-rbuilderas an artifact target in thereleaseworkflowbuildjob inreleaseworkflow inside container/.github/directory💡 Motivation and Context
we need to store the binary for
reth-rbuilderas an artifact.while I was making these changes I ran into a dependency conflict with
GLIBCso I included this change as well (happy to separate if needed). the downside of doing this, is that it doesn't work on macos runners, so I've disabled that for now.✅ I have completed the following steps:
successful run here https://github.com/flashbots/rbuilder/actions/runs/12130028687