redact sensitive feature flag #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo. Validation refactor.
Validation errors redacted.
liamaharon
force-pushed
the
filter-external-logs-ff
branch
3 times, most recently
from
a067484 to
c270395
Compare
liamaharon
force-pushed
the
filter-external-logs-ff
branch
from
c270395 to
2a6da9e
Compare
liamaharon
requested review from
dvush,
ZanCorDX,
ferranbt,
metachris and
jakubhruby7
as code owners
ferranbt
reviewed
Sep 12, 2024
ZanCorDX
approved these changes
Sep 12, 2024
metachris
approved these changes
Sep 13, 2024
ZanCorDX
reviewed
Sep 13, 2024
ZanCorDX
requested changes
Sep 13, 2024
Yes good catch, I missed that that also needs redacting from your previous PR. Fixing. |
liamaharon
force-pushed
the
filter-external-logs-ff
branch
from
76b675b to
1bae2c3
Compare
liamaharon
force-pushed
the
filter-external-logs-ff
branch
from
1bae2c3 to
f315762
Compare
ZanCorDX
approved these changes
Sep 13, 2024
astarinmymind
pushed a commit
that referenced
this pull request
Oct 3, 2024
demo for @ZanCorDX Idea is to redact the error `Display` and `Debug` implementation where the error is defined, rather than creating new layers of wrapper we need to maintain and remember to use --------- Co-authored-by: Daniel Xifra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demo for @ZanCorDX
Idea is to redact the error
DisplayandDebugimplementation where the error is defined, rather than creating new layers of wrapper we need to maintain and remember to use