feat: Add a vec of trait datasources to historical data fetcher #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
requested review from
dvush,
ZanCorDX,
metachris and
jakubhruby7
as code owners
3 tasks
Benchmark results for
|
| Date (UTC) | 2024-07-09T04:28:52+00:00 |
| Commit | 5f37b721a20f19fd8a3768848a462cabdc536fb2 |
| Base SHA | b2cb71773c8d0c679ff56cd39b79010e6a48ed34 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| MEV-Boost SubmitBlock serialization/JSON encoding | -8.12% | Performance has improved. |
metachris
changed the title
metachris
approved these changes
Jul 5, 2024
dvush
reviewed
Jul 8, 2024
| #[async_trait] | ||
| pub trait Datasource: std::fmt::Debug { | ||
| async fn get_data(&self, block: BlockRef) -> eyre::Result<Vec<OrdersWithTimestamp>>; | ||
| fn clone_box(&self) -> Box<dyn Datasource>; |
There was a problem hiding this comment.
Why this instead of making Datasource Clonable (the same way it has std::fmt::Debug)?
There was a problem hiding this comment.
I tried it but it does not work. Do not have enough context in Rust to know. This was generated by Claude but also a common pattern I found for this use case of storing vec<box>>
There was a problem hiding this comment.
dyn can't be used with Clonable since it's Sized :(.
ZanCorDX
requested changes
Jul 8, 2024
ZanCorDX
approved these changes
Jul 10, 2024
ferranbt
added a commit
that referenced
this pull request
Jul 15, 2024
## 📝 Summary Builds on top of #13. This PR moves the initialisation of the mempool dumpster to the mempool dumpster datasource itself. Before, it was on the fetch command. This also enables a unit test that was ignored before. --- ## ✅ I have completed the following steps: * [x] Run `make lint` * [x] Run `make test` * [x] Added tests (if applicable)
MoeMahhouk
pushed a commit
that referenced
this pull request
Jul 29, 2024
## 📝 Summary Builds on top of #13. This PR moves the initialisation of the mempool dumpster to the mempool dumpster datasource itself. Before, it was on the fetch command. This also enables a unit test that was ignored before. --- ## ✅ I have completed the following steps: * [x] Run `make lint` * [x] Run `make test` * [x] Added tests (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR removes the hardcoded data sources in the HistoricalDataFetcher and replaces them with a dynamic Datasource trait.
💡 Motivation and Context
Before, the two main data sources (mempool dumpster, fb relay) were hardcoded in the HistoricalDataFetcher service. Now, the structure is more flexible and new data sources can be plugged into the HistoricalDataFetcher without any changes to it.
✅ I have completed the following steps:
make lintmake test