Skip to content

Commit

Permalink
Demoted traces (#271)
Browse files Browse the repository at this point in the history
## πŸ“ Summary

Demoted some error! to info/warn.

## πŸ’‘ Motivation and Context

These were giving fake emergency signals.

## βœ… I have completed the following steps:

* [X] Run `make lint`
* [X] Run `make test`
* [ ] Added tests (if applicable)
  • Loading branch information
ZanCorDX authored Dec 8, 2024
1 parent 7239fa5 commit fac0b03
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions crates/rbuilder/src/building/builders/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ use reth_provider::{DatabaseProviderFactory, StateProviderFactory};
use std::{fmt::Debug, marker::PhantomData, sync::Arc};
use tokio::sync::{broadcast, broadcast::error::TryRecvError};
use tokio_util::sync::CancellationToken;
use tracing::{error, warn};
use tracing::{info, warn};

/// Block we built
#[derive(Debug, Clone)]
Expand Down Expand Up @@ -249,7 +249,7 @@ pub fn handle_building_error(err: eyre::Report) -> bool {
let err_str = err.to_string();
if !err_str.contains("Profit too low") {
if is_provider_factory_health_error(&err) {
error!(?err, "Cancelling building due to provider factory error");
info!(?err, "Cancelling building due to provider factory error");
return false;
} else {
warn!(?err, "Error filling orders");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use alloy_primitives::{utils::format_ether, Address, BlockNumber, U256};
use reth::providers::{HeaderProvider, ProviderError};
use reth_provider::StateProviderFactory;
use time::{error, OffsetDateTime};
use tracing::{error, info};
use tracing::{error, info, warn};

use crate::telemetry::{add_subsidy_value, inc_subsidized_blocks};

Expand Down Expand Up @@ -144,7 +144,8 @@ where
) -> Result<Vec<LandedBlockInfo>, WalletError> {
if new_block <= self.block_number {
if new_block < self.block_number {
error!(
// This happens due to reorgs and or weird slot/block generated by the CL
warn!(
new_block,
self.block_number, "Tried to update WalletBalanceWatcher to the past"
);
Expand Down

0 comments on commit fac0b03

Please sign in to comment.