features passed at runtime and artifact names include version

flashbots · Dec 4, 2024 · 9fe3d75 · 9fe3d75
1 parent 921db00
commit 9fe3d75
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -16,6 +16,10 @@ on:
         required: false
         type: boolean
         default: true
+      features:
+        description: "Compilation Features"
+        required: false
+        type: string
       draft-release:
         description: "Draft Release"
         required: false
@@ -54,7 +58,7 @@ jobs:
   build-binary:
     name: Build binary
     needs: extract-version
-    if: ${{ github.event.inputs.build-binary == 'true' || github.event_name == 'push'}} # when manually triggered or version tagged
+    if: ${{ inputs.build-binary == 'true' || github.event_name == 'push'}} # when manually triggered or version tagged
     runs-on: ${{ matrix.configs.runner }}
     container:
       image: ubuntu:22.04
@@ -73,9 +77,9 @@ jobs:
           # Paused until docker is pre-installed https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md
           # - target: aarch64-apple-darwin
           #   runner: warp-macos-14-arm64-6x
-        features:
-          - ""
-          - "redact-sensitive"
+        features: ${{ inputs.features }}
+          # - ""
+          # - "redact-sensitive"
 
     steps:
       - name: Install dependencies
@@ -102,18 +106,18 @@ jobs:
       - name: Upload rbuilder artifact
         uses: actions/upload-artifact@v4
         with:
-          name: rbuilder-${{ matrix.configs.target }}${{ matrix.features && '-' }}${{ matrix.features }}
+          name: rbuilder-${VERSION}-${{ matrix.configs.target }}${{ matrix.features && '-' }}${{ matrix.features }}
           path: target/${{ matrix.configs.target }}/release/rbuilder
 
       - name: Upload reth-rbuilder artifact
         uses: actions/upload-artifact@v4
         with:
-          name: reth-rbuilder-${{ matrix.configs.target }}${{ matrix.features && '-' }}${{ matrix.features }}
+          name: reth-rbuilder-${VERSION}-${{ matrix.configs.target }}${{ matrix.features && '-' }}${{ matrix.features }}
           path: target/${{ matrix.configs.target }}/release/reth-rbuilder
 
   draft-release:
     name: Draft release
-    if: ${{ github.event.inputs.draft-release == 'true' || github.event_name == 'push'}} # when manually triggered or version tagged
+    if: ${{ inputs.draft-release == 'true' || github.event_name == 'push'}} # when manually triggered or version tagged
     needs: [extract-version, build-binary]
     runs-on: warp-ubuntu-latest-x64-16x
     env:
@@ -154,7 +158,7 @@ jobs:
           echo "${{ steps.create-release-draft.outputs.url }}" >> $GITHUB_STEP_SUMMARY
 
   build-docker:
-    if: ${{ github.event.inputs.build-docker == 'true' }}
+    if: ${{ inputs.build-docker == 'true' }}
     name: Build and publish Docker image
     needs: extract-version
     runs-on: warp-ubuntu-latest-x64-16x