Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename 'enable' to 'enabled' in the helm chart #2297

Merged

Conversation

santilococo
Copy link
Contributor

This MR updates the enable parameter in the helm chart from PR #2045 to enabled for consistency with the other parameters.

This change reduces confusion and standardizes the naming convention.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2024

CLA assistant check
All committers have signed the CLA.

@santilococo santilococo force-pushed the feature/standardize_enabled_param branch from 648ae21 to 8515a7f Compare October 25, 2024 10:27
@santilococo santilococo force-pushed the feature/standardize_enabled_param branch from 8515a7f to f80673f Compare October 25, 2024 10:54
@moshloop
Copy link
Member

Hi @santilococo - Thanks for the contribution, can you run make values.schema.deref.json README.md in the charts directory? That should fix the tests

@santilococo
Copy link
Contributor Author

@moshloop, done. It changed the enable to enabled but also added several required: [] in the chart/values.schema.deref.json file. Let me know if I should remove these or make any other changes

@moshloop moshloop enabled auto-merge (squash) October 31, 2024 20:01
@moshloop moshloop merged commit 3a2ee3f into flanksource:master Oct 31, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants