fix: dns check to use lowercase and update fixtures

checks/dns.go

@@ -12,6 +12,7 @@ import (
 	"github.com/flanksource/canary-checker/api/external"
 	v1 "github.com/flanksource/canary-checker/api/v1"
 	"github.com/flanksource/canary-checker/pkg"
+	"github.com/samber/lo"
 	"golang.org/x/net/context"
 )
 
@@ -213,6 +214,8 @@ func checkResult(got []string, check v1.DNSCheck) (result bool, message string)
 	}
 
 	if len(check.ExactReply) != 0 {
+		got = lo.Map(got, func(s string, _ int) string { return strings.ToLower(s) })
+		expected = lo.Map(expected, func(s string, _ int) string { return strings.ToLower(s) })
 		sort.Strings(got)
 		sort.Strings(expected)
 		if !reflect.DeepEqual(got, expected) {

fixtures/minimal/dns_pass.yaml

@@ -39,11 +39,16 @@ spec:
       querytype: "MX"
       minrecords: 1
       exactreply:
-        - "aspmx.l.google.com. 1"
-        - "alt1.aspmx.l.google.com. 5"
-        - "alt2.aspmx.l.google.com. 5"
-        - "aspmx3.googlemail.com. 10"
-        - "aspmx2.googlemail.com. 10"
+        - aspmx.l.google.com. 1
+        - aspmx.l.google.com. 1
+        - alt1.aspmx.l.google.com. 5
+        - alt2.aspmx.l.google.com. 5
+        - alt2.aspmx.l.google.com. 5
+        - alt1.aspmx.l.google.com. 5
+        - aspmx2.googlemail.com. 10
+        - aspmx3.googlemail.com. 10
+        - aspmx3.googlemail.com. 10
+        - aspmx2.googlemail.com. 10
       timeout: 100
       thresholdMillis: 1000
     - server: 8.8.8.8
@@ -61,10 +66,8 @@ spec:
       querytype: "NS"
       minrecords: 1
       exactreply:
-        - "ns-91.awsdns-11.com."
-        - "ns-908.awsdns-49.net."
-        - "ns-1450.awsdns-53.org."
-        - "ns-1896.awsdns-45.co.uk."
+        - "gina.ns.cloudflare.com."
+        - "walt.ns.cloudflare.com."
       timeout: 100
       thresholdMillis: 1000
   #  - server: 8.8.8.8