Fix issues with loop variable of io implied do loop #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing codegen was for loop variables in io implied do loop was not working correctly for pointer, allocatable variables. Rather than finding the symbol address directly, use Evaluate Expression to find the correct symbol and find the expression address from it. This is similar to the handling for loop variables in fir.do_loop.
|
Reference: chiyoda_c4a |
schweitzpgi
approved these changes
Apr 18, 2022
| @@ -672,7 +672,8 @@ static void genIoLoop(Fortran::lower::AbstractConverter &converter, | |||
| const auto &itemList = std::get<0>(ioImpliedDo.t); | |||
| const auto &control = std::get<1>(ioImpliedDo.t); | |||
| const auto &loopSym = *control.name.thing.thing.symbol; | |||
| mlir::Value loopVar = converter.getSymbolAddress(loopSym); | |||
There was a problem hiding this comment.
getSymbolAddress() doesn't appear to be used all that often, but seems like it will not work in any situation where the symbol is a boxed variable.
There was a problem hiding this comment.
It is used in OpenMP/OpenACC lowering in a few other places. Filed an issue #1595 to capture this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing codegen was for loop variables in io implied do loop
was not working correctly for pointer, allocatable variables. Rather
than finding the symbol address directly, use Evaluate Expression to
find the correct symbol and find the expression address from it. This
is similar to the handling for loop variables in fir.do_loop.