chore: Update cicd.yml file on flame_3d to match main, rollback color changes #3378
Conversation
luanpotter
changed the title
| @@ -13,7 +13,7 @@ class RayCastExample extends FlameGame with HasCollisionDetection { | |||
| final velocity = 60; | |||
| double get resetPosition => -canvasSize.y; | |||
|
|
|||
| Paint paint = BasicPalette.red.withOpacity(0.6).paint(); | |||
| Paint paint = Paint()..color = Colors.red.withOpacity(0.6); | |||
There was a problem hiding this comment.
| Paint paint = Paint()..color = Colors.red.withOpacity(0.6); | |
| final Paint paint = Paint()..color = Colors.red.withOpacity(0.6); |
There was a problem hiding this comment.
this is copied as is from main - you can fix on a separate PR!
| @@ -10,7 +10,7 @@ import 'package:flutter/material.dart'; | |||
|
|
|||
| class RayTraceExample extends FlameGame | |||
| with HasCollisionDetection, TapDetector { | |||
| Paint paint = BasicPalette.red.withOpacity(0.6).paint(); | |||
| Paint paint = Paint()..color = Colors.red.withOpacity(0.6); | |||
There was a problem hiding this comment.
| Paint paint = Paint()..color = Colors.red.withOpacity(0.6); | |
| final Paint paint = Paint()..color = Colors.red.withOpacity(0.6); |
There was a problem hiding this comment.
this is copied as is from main - you can fix on a separate PR!
| @@ -13,7 +13,7 @@ class ResizingRectangle extends RectangleComponent { | |||
| void onGameResize(Vector2 size) { | |||
| super.onGameResize(size); | |||
|
|
|||
| this.size = size * 0.4; | |||
| this.size = size * .4; | |||
There was a problem hiding this comment.
| this.size = size * .4; | |
| this.size = size * 0.4; |
There was a problem hiding this comment.
this is copied as is from main - you can fix on a separate PR!
| getPaint(paintId).color.withValues(alpha: opacity), | ||
| paintId: paintId, | ||
| ); | ||
| setColor(getPaint(paintId).color.withOpacity(opacity), paintId: paintId); |
There was a problem hiding this comment.
This was easier to read with the trailing comma
There was a problem hiding this comment.
this is copied as is from main - you can fix on a separate PR!
| Float32List get storage => Float32List.fromList([ | ||
| opacity, | ||
| red.toDouble() / 255, | ||
| green.toDouble() / 255, | ||
| blue.toDouble() / 255, | ||
| ]); |
There was a problem hiding this comment.
I am reverting the color changes to the old version
| @@ -182,7 +182,6 @@ void main() { | |||
| test( | |||
There was a problem hiding this comment.
Only the skips should be changed in this file right?
There was a problem hiding this comment.
I just copied whatever it is in main. it should disappear once I rebase
| @@ -92,6 +92,7 @@ void main() { | |||
| expect(atlas.key, 'images/green.png'); | |||
There was a problem hiding this comment.
Only the skips should be changed in this file right?
There was a problem hiding this comment.
I just copied whatever it is in main. it should disappear once I rebase
Description
Update cicd.yml file on flame_3d to match main.
Since we finally updated main, we should require no difference whatsoever on this file anymore.
This will require downgrading all the color changes, which is fine. This should never have been a part of flame_3d to begin with.
Files were "untouched" by checking out the exact version as they are in main right now (will need to rebase flame_3d to main later). I had to add a couple more files because the files on main had dependencies on changes that are not yet rebased on flame_3d. These extra diffs should disappear when I do the final rebase.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?