Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add WorldRoute to enable swapping worlds from the RouterComponent #3372

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Nov 23, 2024

Description

This PR adds the WorldRoute which acts as a normal route, but instead of adding a new component (page), it swaps out the world that the camera (either the default camera or an explicitly passed in one) is watching.

Screencast.from.2024-11-23.15-58-35.webm

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@spydon spydon changed the title feat: Add WorldRoute enable swapping worlds from the RouterComponent feat: Add WorldRoute to enable swapping worlds from the RouterComponent Nov 23, 2024

class MyWorld2 extends World {
@override
Future<void> onLoad() async {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add super call

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The world's default onLoad is empty?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I don't remember, if it is so, them no worries, was just a nit anyway

@spydon spydon merged commit 497f128 into main Nov 24, 2024
10 checks passed
@spydon spydon deleted the feat/world-route branch November 24, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants