Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Flame Platforms should unify variable for NAME_OF_YOUR_REPOSITORY #3365

Merged
merged 1 commit into from
Nov 13, 2024
Merged

docs: Flame Platforms should unify variable for NAME_OF_YOUR_REPOSITORY #3365

merged 1 commit into from
Nov 13, 2024

Conversation

tenhobi
Copy link
Contributor

@tenhobi tenhobi commented Nov 12, 2024 •
edited
Loading

Fixes #3364

Description

Merges two variables that mean the same thing into one. (NAME_OF_YOUR_REPOSITORY and YOUR_REPO_NAME)

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@tenhobi
Update platforms.md
c47abcb 
Unify name to NAME_OF_YOUR_REPOSITORY
spydon
spydon approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@spydon spydon merged commit cc917df into flame-engine:main Nov 13, 2024
9 checks passed
@tenhobi tenhobi deleted the patch-1 branch November 13, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flame Platforms docs have 2 variables for the same thing
2 participants
@tenhobi @spydon