refactor!: Make TextElement more usable on its own #2679
Merged
+32
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of my ongoing effort to simplify the text rendering pipeline.
My ultimate goal is to:
All details are specified here: refactor!: Simplify text rendering pipeline #2663
As a first step to break down that huge PR, this makes a small change to TextElements to make them more useful
This PR will:
rename render -> draw
draw becomes the "internal", underlying impl, raw method, that just draws the element w/ any custom options
add a new render method that takes in more options
this does not need to be extended by every impl.
this is for end users and accepts parameters like position and anchor to be more in line with the renderer interface
Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Migration instructions
This is technically a breaking change but should have no effect for users, unless you are creating your own custom
TextElement
s. In that case, to migrate:render
method todraw