Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unused variable on dialogue_view_test.dart #2673

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

luanpotter
Copy link
Member

Description

Fix existing issue detect by GitHub's ever-evolving automated analysis:

image

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter requested a review from spydon August 24, 2023 05:08
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather suppress this warning and add a TODO, this seems like a nice feature to have once it is built all the way to the user

@luanpotter
Copy link
Member Author

Hum but this is a private class used one-off on a test file? So should not affect any user whatsoever right? Or am I missing something?

@luanpotter luanpotter requested a review from spydon August 24, 2023 22:31
@spydon
Copy link
Member

spydon commented Aug 25, 2023

Hum but this is a private class used one-off on a test file? So should not affect any user whatsoever right? Or am I missing something?

Aah, you're right, approved!

@spydon spydon merged commit b77802a into main Aug 25, 2023
7 checks passed
@spydon spydon deleted the luan.fix-ci branch August 25, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants