Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update PR template so "Migration instructions" is after the breaking change checkbox #2665

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

luanpotter
Copy link
Member

Description

Update PR template so "Migration instructions" is after the breaking change checkbox.
I believe that was where it was intended to be, but please assess if this makes sense.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@spydon
Copy link
Member

spydon commented Aug 20, 2023

Nice, I've been meaning to fix this for quite a while, but I've always forgotten 😅

@spydon spydon merged commit 7409ec5 into main Aug 20, 2023
6 checks passed
@spydon spydon deleted the luan.template branch August 20, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants