-
-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change DialogueView to a mixin class #2652
Merged
spydon
merged 7 commits into
flame-engine:main
from
projectitis:fix/jenny-dialogueview-as-mixin-class
Aug 20, 2023
Merged
fix: Change DialogueView to a mixin class #2652
spydon
merged 7 commits into
flame-engine:main
from
projectitis:fix/jenny-dialogueview-as-mixin-class
Aug 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync from upstream
Support both subclassing and mixin on DialogueView
projectitis
changed the title
Fix: Change jenny's DialogueView yo a mixin class
Fix: Change jenny's DialogueView to a mixin class
Aug 17, 2023
projectitis
changed the title
Fix: Change jenny's DialogueView to a mixin class
fix: change DialogueView to a mixin class
Aug 17, 2023
projectitis
changed the title
fix: change DialogueView to a mixin class
Fix: change DialogueView to a mixin class
Aug 17, 2023
projectitis
changed the title
Fix: change DialogueView to a mixin class
fix: Change DialogueView to a mixin class
Aug 17, 2023
spydon
reviewed
Aug 18, 2023
Co-authored-by: Lukas Klingsbo <[email protected]>
Ah, didn't know that was possible, thanks @spydon. Tests still pass, too. |
spydon
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks for your contribution! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The DialogueView is responsible for handling and (almost always) displaying the dialog to the user. A very common use case requires the
DialogueView
to be aPositionComponent
or other visual component in the game. This would require extending from bothPositionComponent
andDialogueView
.Problem: The current
DialogueView
implementation is an abstract class. Dart does not support multiple inheritance. This means that the case above is difficult to implement.Solution: Changing the
DialogueView
from an abstract class to a mixin class allows the developer to extendPositionComponent
and mix inDialogueView
. The class can now be used as a base class OR as a mixin. All existing tests still pass. An additional test has been added that validates the use as a mixin (extending one class and mixing inDialogueView
).Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Notes on docs: Updated class docs. Checked doc pages. These still read correctly.
Notes on examples: Currently no jenny examples.
Breaking Change?
Related Issues
NA