Fix regression due to handling of normal range #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bramus Do you have time to review this? |
bramus
approved these changes
Feb 8, 2024
|
Merged it in. Besides the current TODO’s for this code, passing in explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression due to #223
We should return
normalas the default range start and end, but the parsing still expects a TimelineRangeOffset which can cause an issue.Fixing the issue by only returning
normalwhen no range was set by the user, keeping the TimelineRangeOffset from getNormalStart/EndRange otherwise.There's already a todo to handle the full syntax later.