Set default anonymous source to nearest #208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progress demo is currently throwing a "TypeError: Invalid ScrollTimeline Source Type".
This happens because
parseAnonymousScrollTimeline()
does not set a default sourcegetAnonymousSourceElement()
requires a source, and will throw an error if one is not set.Adding 'nearest' as a default anonymous source in
getAnonymousScrollTimelineOptions()
, the same place a default value foraxis
is set.scroll-timeline/src/scroll-timeline-css-parser.js
Lines 465 to 481 in db93642
scroll-timeline/src/scroll-timeline-css-parser.js
Lines 117 to 129 in db93642
scroll-timeline/src/scroll-timeline-base.js
Lines 493 to 504 in db93642