Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle explicitly undefined options argument in updateTimingHandler #197

Conversation

johannesodland
Copy link
Contributor

This is a follow up on #191.

Handle case where effect.updateTiming() is called with an explicit undefined options argument.

This happens in the view-timeline-subject-size-changes test.

After a discussion in #191 we skipped checking for an explicitly undefined options argument, and instead returned if the argumentList was undefined or empty. That does not cover the case where the method is called explicitly with undefined as an argument as below.

effect.updateTiming(undefined)
// argumentList == [undefined]
// arguementList.length == 1

@johannesodland
Copy link
Contributor Author

@bramus I realized our changes in #191 doesn't handle the case where undefined is passed explicitly as an argument to updateTiming(), as it is done in the WPT subtest. Do you mind reviewing this PR?

@bramus bramus merged commit 147d187 into flackr:master Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants