Don’t try ticking the animation if there are no details #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is a regression introduce by #89. When using the polyfill in Safari (which hash a BFCache), one would get errors about trying to read
autoAlignStartTimefrom thedetails.Narrowing things down and working my way up the call tree, the root cause is in
tickAnimationwhich tries to get thedetailsfrom theproxyAnimations. SinceproxyAnimationsgets cleared onpagehide,detailscan be empty, so the whole ticking stop stop if no details are present.This PR fixes that.